Clear npm audit vulnerabilities#58
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
Conversation
Signed-off-by: darshan-jahagirdar <bobbyfirmino195@gmail.com>
a807c0d to
b16cc3e
Compare
Author
|
Validation update for this PR: Result: I also checked the test command earlier; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40.
The package already declares
mongodb^3.3.3, but the lockfile still resolved vulnerable transitive packages, includingbson@1.1.1. This refreshes the lockfile to patchedbson@1.1.6, updates the pinned Vows dev dependency to0.8.3so the full audit is clean, and changes the test script fromnode node_modules/.bin/vowstovowsso it invokes the cross-platform npm shim.Bounty: targets the $20 Bountysource bounty linked from #40.
Verification:
npm installnpm audit --jsonreports0vulnerabilitiesnpm testnow invokesvowscorrectly, then stops because this checkout does not includetest/db.config.json/ a MongoDB service for the integration suite.git diff --cached --checkpassed before commit.