Allow force-quit if a transaction is running#1573
Open
maximsmol wants to merge 2 commits intodbcli:mainfrom
Open
Allow force-quit if a transaction is running#1573maximsmol wants to merge 2 commits intodbcli:mainfrom
maximsmol wants to merge 2 commits intodbcli:mainfrom
Conversation
Signed-off-by: maximsmol <1472826+maximsmol@users.noreply.github.com>
Signed-off-by: maximsmol <1472826+maximsmol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently if pgcli detects an active transaction, it will not allow quitting with ^D or the
quitcommand. This means the user is stuck until the transaction finishes. I've been working around this issue with bash job control (^Z to suspend, then killing the process manually).Note that the
ROLLBACKoption does not work since the connection has a query in progress:This is particularly problematic in two cases:
pg_sleep(3600))This patch simply adds a
forceoption to the in-transaction exit dialog that allows exiting annyway.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).