dbeaver/pro#9665 adds global network profiles - #4465
Open
sergeyteleshev wants to merge 14 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 23 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
marked this pull request as ready for review
July 20, 2026 09:44
devnaumov
reviewed
Jul 20, 2026
| } | ||
|
|
||
| @injectable(() => [AdministrationItemService]) | ||
| export class ConnectionsAdministrationService extends Bootstrap { |
Member
There was a problem hiding this comment.
ConnectionsAdministrationServiceBootstrap
| this.tabsContainer = new TabsContainer('Connections administration tabs'); | ||
| } | ||
|
|
||
| addTab({ onActivate, onDeActivate, ...tabInfo }: IConnectionsTabOptions): void { |
Member
There was a problem hiding this comment.
please dont add such logic to the bootstrap services, use general services for it, containers should be declared there also
Contributor
Author
There was a problem hiding this comment.
separated logic to tab service and bootstrap
devnaumov
previously approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/9665