Conversation
`jp query --no-edit` skipped the flag whenever stdin was piped without an inline query argument: the editor still opened even though the user explicitly asked to suppress it. The check for `--no-edit` only ran when the request body was still empty, so piped stdin content (which fills the request) bypassed it. `edit_message` now also omits the editor when `--no-edit` is set, regardless of whether piped stdin already produced a non-empty request. Piping content and passing `--no-edit` now reliably skips the editor, e.g. `echo "hi" | jp query --no-edit`. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jp query --no-editskipped the flag whenever stdin was piped without an inline query argument: the editor still opened even though the user explicitly asked to suppress it. The check for--no-editonly ran when the request body was still empty, so piped stdin content (which fills the request) bypassed it.edit_messagenow also omits the editor when--no-editis set, regardless of whether piped stdin already produced a non-empty request. Piping content and passing--no-editnow reliably skips the editor, e.g.echo "hi" | jp query --no-edit.