chore(tools): Parse JSON trace-log marker in debug_jp#867
Merged
Conversation
`debug_jp` locates jp's trace log by scanning stderr for the text
marker `Full trace log written to: <path>`. When jp runs with
`--format json` or `json-pretty`, it emits a `{"trace_log": "<path>"}`
object instead, so the tool failed to find the trace file and reported
a spurious "trace log not found" error for any JSON-format run.
`trace_parse` gains `extract_trace_path`, which recognizes either
shape, and `is_trace_path_marker_line`, used to strip the marker line
from the stderr shown in rendered reports so it doesn't show up
twice (once in the footer, once in the raw stderr dump).
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug_jplocates jp's trace log by scanning stderr for the text markerFull trace log written to: <path>. When jp runs with--format jsonorjson-pretty, it emits a{"trace_log": "<path>"}object instead, so the tool failed to find the trace file and reported a spurious "trace log not found" error for any JSON-format run.trace_parsegainsextract_trace_path, which recognizes either shape, andis_trace_path_marker_line, used to strip the marker line from the stderr shown in rendered reports so it doesn't show up twice (once in the footer, once in the raw stderr dump).