-
Notifications
You must be signed in to change notification settings - Fork 227
Updated dependencies and introduced delete option with test #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristianmandrup
wants to merge
5
commits into
dchester:master
Choose a base branch
from
kristianmandrup:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−9
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d4588b3
add special delete option to apply
kristianmandrup cb51ed0
downgrade to esprima v2. v3 raises Unexpected token ILLEGAL
kristianmandrup 06e9a1d
enable delete from parent Array or Object using special return value …
kristianmandrup fd7aac5
change remove key to sth more unique and update docs with delete exam…
kristianmandrup f55ac4c
added filter method
kristianmandrup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| { | ||
| "name": "jsonpath", | ||
| "description": "Query JavaScript objects with JSONPath expressions. Robust / safe JSONPath engine for Node.js.", | ||
| "version": "0.2.7", | ||
| "version": "0.2.8", | ||
| "author": "david@fmail.co.uk", | ||
| "scripts": { | ||
| "postinstall": "node lib/aesprim.js > generated/aesprim-browser.js", | ||
| "test": "mocha -u tdd test && jscs lib && jshint lib", | ||
| "generate": "node bin/generate_parser.js > generated/parser.js" | ||
| }, | ||
| "dependencies": { | ||
| "esprima": "1.2.2", | ||
| "jison": "0.4.13", | ||
| "static-eval": "0.2.3", | ||
| "underscore": "1.7.0" | ||
| "esprima": "^2.0.0", | ||
| "jison": "^0.4.17", | ||
| "lodash.filter": "^4.6.0", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kristianmandrup I don't see where |
||
| "lodash.remove": "^4.7.0", | ||
| "static-eval": "^1.1.1", | ||
| "underscore": "^1.8.3" | ||
| }, | ||
| "browser": { | ||
| "./lib/aesprim.js": "./generated/aesprim-browser.js" | ||
|
|
@@ -24,7 +26,7 @@ | |
| "grunt-contrib-uglify": "0.9.1", | ||
| "jscs": "1.10.0", | ||
| "jshint": "2.6.0", | ||
| "mocha": "2.1.0" | ||
| "mocha": "^3.1.0" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristianmandrup Why do you need special
:delete:value you can simply detect when callback returnsundefined.:delete:.IMHO, it's bad practice to create magic values.