Rename API gateway URL settings to control-plane - #22
Conversation
Add control-plane-url flag, DCM_CONTROL_PLANE_URL, and :8080 default. Keep legacy api-gateway names as aliases. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gabriel-farache
left a comment
gabriel-farache
left a comment
There was a problem hiding this comment.
I see the .ai/specs were not updated with the change, could you either remove them or update them to avoid having discrepancies?
Note that if you remove the folder, the comment referencing them should also be deleted
Drop catalog-manager, policy-manager, and service-provider-manager. Pin control-plane at e4374fc25292. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
I totally forgot about them. |
Thx. |
| | REQ-SPP-030 | `dcm sp provider get` MUST accept a `PROVIDER_ID` positional argument and display the SP provider | MUST | | | ||
| | REQ-SPP-040 | Missing `PROVIDER_ID` argument for `get` MUST result in a usage error (exit code 2) | MUST | | | ||
| | REQ-SPP-050 | All SP provider commands MUST use the generated SP Manager client (`service-provider-manager/pkg/client`) | MUST | | | ||
| | REQ-SPP-050 | All SP provider commands MUST use the generated SP provider client (`github.com/dcm-project/control-plane/pkg/sp/client/provider`) | MUST | | |
There was a problem hiding this comment.
so we are changing the name of SP Resource Manager to SP Provider?
I just want to make sure this is intentional
There was a problem hiding this comment.
The Resource Manager is inside the SP Manager. Since it's in process I'm unsure TBH about the naming. I can revert it. WDYT?
There was a problem hiding this comment.
I think we are using SPRM in a lot of places so changing the name in this PR, in this repo, for the first time does not seem right
Reverted 02e71f1 |
|
@gciavarrini I think that once you cleaned the commit history you are good to merge :) |
This reverts commit 9cfa19d. Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
## Why DCM service repos push `:main` and `:sha` container images to Quay on every merge, but the CLI repo only produced binaries on `v*` tag pushes. Merged-but-untagged changes (like the `--control-plane-url` rename in #22) were unavailable to the E2E test harness until someone cut a release. This adds the CLI equivalent — two pre-releases on every push to main: - **`main`** — rolling, replaced on every push (convenience pointer, like `:main` image tag) - **`<sha7>`** — immutable, accumulates (pinnable reference, like `:sha` image tag) ## What changed - Replaced `tag-release.yaml` + the old inline `release.yaml` with a single unified workflow - On push to main: GoReleaser snapshot build → uploads to both a rolling `main` pre-release and an immutable `<sha7>` pre-release - On `v*` tag push: formal GoReleaser release (same behavior as before) - Added `snapshot.version_template` to `.goreleaser.yaml` for consistent artifact naming (`0.3.2-next+c2365dd`) - Added concurrency group keyed on `github.ref` so rapid main pushes cancel stale runs (tag pushes are in a separate group and never get cancelled) - CI/lint gate restored as `needs:` dependencies on the release job — `ci.yaml` and `lint.yaml` don't trigger on tag pushes, so without this a tag release could ship broken binaries ## Verified - GoReleaser snapshot builds all 6 platform archives + checksums locally - Full end-to-end on fork: - **Workflow run:** https://github.com/chadcrum/cli/actions/runs/28459205036 - **Rolling release:** https://github.com/chadcrum/cli/releases/tag/main - **SHA release:** https://github.com/chadcrum/cli/releases/tag/c2365dd - Both pre-releases created with all 6 platform archives + checksums ## Related - FLPATH-4426 - Companion: dcm-project/shared-workflows#26 (adds `cli` to `ALL_SERVICES` in `hack/tag-release.sh`) Signed-off-by: Chad Crum <1462069+chadcrum@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
4 participants
Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini gciavarrini@redhat.com