Skip to content

feat: parse Street Brawl item draft bucketing#397

Merged
Vergir merged 2 commits into
developfrom
feature/street-brawl-item-bucketing
Jul 16, 2026
Merged

feat: parse Street Brawl item draft bucketing#397
Vergir merged 2 commits into
developfrom
feature/street-brawl-item-bucketing

Conversation

@Vergir

@Vergir Vergir commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Parse m_mapItemDraftBucketing and m_mapItemDraftCounterWeights into a heradata.json. This will allow to list items that are more/less likely to be drafted for each hero in Street Brawl.

Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data

@Vergir

Vergir commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

One thing I'm a bit on the fence about is that it our hero_data gets quite bigger: from 200kb to 1.6mb. Lines count from 6k to 52k. CSV is roughtly same. We can move the new data to a separate file, like street_brawl.json, but I'm not sure if it's a good idea, to separate it like this. In the end i chose to stay in hero_data, but open to any corrections here.

@hassayag

Copy link
Copy Markdown
Member

One thing I'm a bit on the fence about is that it our hero_data gets quite bigger: from 200kb to 1.6mb. Lines count from 6k to 52k. CSV is roughtly same. We can move the new data to a separate file, like street_brawl.json, but I'm not sure if it's a good idea, to separate it like this. In the end i chose to stay in hero_data, but open to any corrections here.

Yeah I'd agree it is too large for the hero json file, especially if we think this would be used on a page separate from each hero's main page. Have you seen any patterns in the data that show certain heroes share X set of weights? As I can see that one of the sets is used across 24 heroes

Vergir added 2 commits July 11, 2026 16:32
…json

Parse m_mapItemDraftBucketing and m_mapItemDraftCounterWeights from hero
data into a dedicated street-brawl-data.json under an "item-buckets"
object, instead of bloating hero-data.json.

Every hero shares one pool of draftable items (AvailableItems) that
default to the "Normal" bucket at weight 1.0. Only per-(hero, item)
deviations are stored, as a flat Outliers edge list carrying whichever of
Bucket / Weight / Counter differ from that default. The full bucketing is
reconstructed as Normal @ 1.0 unless an outlier overrides it.

Registers the StreetBrawlData.json wiki data page.
@Vergir
Vergir force-pushed the feature/street-brawl-item-bucketing branch from eae2a68 to c74cbb1 Compare July 11, 2026 14:33
@Vergir

Vergir commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah I'd agree it is too large for the hero json file, especially if we think this would be used on a page separate from each hero's main page. Have you seen any patterns in the data that show certain heroes share X set of weights? As I can see that one of the sets is used across 24 heroes

The 24 heroes you mentioned is a set used for unreleased heroes (Raven-Slork etc). I also found that there's a default set of 178 items that are used for all heroes that can be minimized.

I've done some data normalization, and it's much smaller now: from 1.2mb to 200kb. Also I redirected data to a separate file street-brawl-data.json. See if you like it better now?

@Vergir

Vergir commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

I've redone the parsing with the latest changes, see here
https://github.com/deadlock-wiki/deadlock-data/pull/241/changes

Also, if any comments or further edits are required, I suggest to move this discussion to discord server, it's way easier to communicate there :)

@Vergir
Vergir requested review from hassayag and removed request for hassayag July 11, 2026 14:56

@hassayag hassayag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the default/outlier system is a nice way of laying it out 🚀

@Vergir
Vergir merged commit 7f8a0f0 into develop Jul 16, 2026
5 checks passed
@Vergir
Vergir deleted the feature/street-brawl-item-bucketing branch July 16, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants