[Snyk] Security upgrade marshmallow from 3.19.0 to 3.26.2#16
Conversation
…ities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-MARSHMALLOW-14550833
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds marshmallow>=3.26.2 to the requirements file for Airflow 1 samples to address a Snyk vulnerability. The reviewer correctly identified that this change introduces a direct conflict with constraints.txt (which pins marshmallow==2.21.0), leading to installation failures. Additionally, upgrading marshmallow to v3 is a major breaking change incompatible with Airflow 1.10.15.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| apache-airflow-backport-providers-cncf-kubernetes==2021.3.3 | ||
| kubernetes==11.0.0 | ||
| scipy==1.4.1; python_version > '3.0' | ||
| marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Adding marshmallow>=3.26.2 introduces a direct conflict with constraints.txt (line 194), which pins marshmallow==2.21.0. This conflict will cause pip install to fail when installing with the constraints file. Furthermore, upgrading marshmallow from v2 to v3 is a major breaking change that is incompatible with Apache Airflow 1.10.15 and its associated dependencies (such as Flask-AppBuilder 2.3.4).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="composer/airflow_1_samples/requirements.txt">
<violation number="1" location="composer/airflow_1_samples/requirements.txt:8">
P2: `>=3.26.2` is not a pin; it allows uncontrolled upgrades and contradicts the comment.</violation>
<violation number="2" location="composer/airflow_1_samples/requirements.txt:8">
P1: This new requirement conflicts with `constraints.txt`, so constrained installs become unsatisfiable.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| apache-airflow-backport-providers-cncf-kubernetes==2021.3.3 | ||
| kubernetes==11.0.0 | ||
| scipy==1.4.1; python_version > '3.0' | ||
| marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
P1: This new requirement conflicts with constraints.txt, so constrained installs become unsatisfiable.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At composer/airflow_1_samples/requirements.txt, line 8:
<comment>This new requirement conflicts with `constraints.txt`, so constrained installs become unsatisfiable.</comment>
<file context>
@@ -5,3 +5,4 @@ apache-airflow-backport-providers-google==2021.3.3
apache-airflow-backport-providers-cncf-kubernetes==2021.3.3
kubernetes==11.0.0
scipy==1.4.1; python_version > '3.0'
+marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>
| apache-airflow-backport-providers-cncf-kubernetes==2021.3.3 | ||
| kubernetes==11.0.0 | ||
| scipy==1.4.1; python_version > '3.0' | ||
| marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
P2: >=3.26.2 is not a pin; it allows uncontrolled upgrades and contradicts the comment.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At composer/airflow_1_samples/requirements.txt, line 8:
<comment>`>=3.26.2` is not a pin; it allows uncontrolled upgrades and contradicts the comment.</comment>
<file context>
@@ -5,3 +5,4 @@ apache-airflow-backport-providers-google==2021.3.3
apache-airflow-backport-providers-cncf-kubernetes==2021.3.3
kubernetes==11.0.0
scipy==1.4.1; python_version > '3.0'
+marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>
| marshmallow>=3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability | |
| marshmallow==3.26.2 # not directly required, pinned by Snyk to avoid a vulnerability |
2 participants
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
composer/airflow_1_samples/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by cubic
Pin
marshmallowto >=3.26.2 incomposer/airflow_1_samples/requirements.txtto address a known vulnerability and reduce security risk. No application code changes; only the dependency constraint was added.Written for commit 7f50f20. Summary will update on new commits.