Repository navigation
test(session-tree): make wait-for-stop race tests deterministic - #1095
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main’s Windows CI run failed because the tree-aware wait tests mixed automatic fake-clock ticks with exact manual timing. A real scheduling delay could complete the 10 ms landing read before the test resumed the child, returning a paused result instead of exercising deadline preservation.
Use a manually advanced clock throughout this suite, explicitly drive startup and settled-stop reads, and add a controlled 40 ms real scheduling delay to the deadline regression. The fake clock must remain at 5 ms, and the existing 99 ms pending / 100 ms timeout assertions remain intact. This is a test-only fix; runtime behavior and coverage requirements are unchanged.
Validation: reproduced the original CI result with the scheduling delay; the fixed suite passes all 19 tests. Both wait suites pass together (39 tests), including shuffled order with Istanbul instrumentation. The required pre-push gate passed lint, typecheck, clean build, 8,159 unit tests and 149 integration tests. Follow-up to #1094.