Skip to content

test(cli): retain doctor subprocess failure diagnostics - #1099

Merged
debugmcpdev merged 2 commits into
debugmcp:mainfrom
gezerui888:fix/doctor-failure-diagnostics
Nov 7, 2026
Merged

debugmcpdev merged 2 commits into
debugmcp:mainfrom
gezerui888:fix/doctor-failure-diagnostics

Conversation

@gezerui888

Copy link
Copy Markdown
Contributor

📋 Description

I added subprocess diagnostics to doctorRust() so CI failures retain the exit code, signal, killed flag, stdout and stderr. The original error remains the cause.

The regression cases cover nonzero exits with JSON output, empty output and a parent timeout. The existing metadata assertions and production timeouts are unchanged.

Fixes #1098.

🔄 Type of Change

  • 🧪 Test improvement

✅ Checklist

  • My code follows the project style.
  • I reviewed the change.
  • The change adds no warnings.
  • Regression tests fail without the diagnostic message and pass with it.
  • Tests have no new failures relative to main.
  • Documentation and downstream changes are not needed for this test helper.

🧪 Testing

pnpm lint
pnpm typecheck:all
npm run build
npm run test:unit
npm run test:integration

The seven doctor cases pass. The CI dot and JSON reporters retain all diagnostic fields in controlled failures.

Full unit tests have identical results on main and this branch: 8,160 passed, one failed and three skipped. The failure is the Dart factory's real Flutter discovery probe exceeding its test budget.

The full integration suite passes: 144 tests, with nine existing skips.

Personal-path, documentation and changelog checks pass.

Test Configuration:

  • OS: macOS arm64
  • Node: 22.23.4
  • Python: 3.12

cc @debugmcpdev

Signed-off-by: gezerui0124 <gezerui1997@gmail.com>
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-06T20:27:31.195631Z
We couldn’t complete this review. Comment @codex review to try again.
b3e8935 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@debugmcpdev

Copy link
Copy Markdown
Collaborator

Merged — thank you, @gezerui888. This is exactly the first step #1098 asked for, and it landed within hours of the ticket.

What it will show, for the record: the failure behind #1098 was a bare Command failed with an empty stderr line, which fits a slow cargo -vV on a loaded runner — the rust probe times out, the verdict goes broken, doctor exits 1 with the JSON report on stdout, and the old helper dropped that report. The next sighting prints it (probe.timedOut, durationMs), and the choice between more budget and asserting on the report regardless of the exit code follows from that measurement; I left that on #1098.

Two follow-ups came out of the review, neither on you:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flake: doctor-codelldb-version.test.ts on windows-latest fails with a bare "Command failed" — the test hides the CLI's exit code and stderr

2 participants