Repository navigation
test(cli): retain doctor subprocess failure diagnostics - #1099
Conversation
Signed-off-by: gezerui0124 <gezerui1997@gmail.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Merged — thank you, @gezerui888. This is exactly the first step #1098 asked for, and it landed within hours of the ticket. What it will show, for the record: the failure behind #1098 was a bare Two follow-ups came out of the review, neither on you:
|
📋 Description
I added subprocess diagnostics to
doctorRust()so CI failures retain the exit code, signal, killed flag, stdout and stderr. The original error remains the cause.The regression cases cover nonzero exits with JSON output, empty output and a parent timeout. The existing metadata assertions and production timeouts are unchanged.
Fixes #1098.
🔄 Type of Change
✅ Checklist
🧪 Testing
The seven doctor cases pass. The CI dot and JSON reporters retain all diagnostic fields in controlled failures.
Full unit tests have identical results on main and this branch: 8,160 passed, one failed and three skipped. The failure is the Dart factory's real Flutter discovery probe exceeding its test budget.
The full integration suite passes: 144 tests, with nine existing skips.
Personal-path, documentation and changelog checks pass.
Test Configuration:
cc @debugmcpdev