Fix Start DECKIO task with a runnable engine demo#40
Open
DevSecNinja wants to merge 1 commit into
Open
Conversation
The Start DECKIO task forwarded to a missing 'dev' script in @deckio/deck-engine, so it failed immediately. Add a small Vite demo app under packages/deck-engine/demo and a 'dev' script so the task launches a real, hot-reloading preview of the engine slides. - .vscode/tasks.json: run 'npm run dev' (drop the invalid '-- --host' npm arg that triggered the warning/failure) - packages/deck-engine: add 'dev' script + demo Vite config/app and dev-only deps (@vitejs/plugin-react@5 for Vite 7, react, react-dom, vite); demo/ is excluded from the published package - .gitignore: ignore Vite's .vite/ dev cache - .vscode/mcp.json: add GitHub MCP server config
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Start DECKIO task failed immediately because it forwarded to a
devscript that does not exist in@deckio/deck-engine:The root
devscript chains into the engine workspace (npm run dev -w @deckio/deck-engine), but that package only defined publishing/versioning scripts — there was no runnable app. The task also passed an invalid-- --hostnpm arg, producing anUnknown cli config "--host"warning.This PR makes the task launch a real, hot-reloading preview of the engine's own slides.
Changes
.vscode/tasks.json— runnpm run dev(dropped the invalid-- --hostarg).packages/deck-engine/package.json— add adevscript (vite demo --host) and dev-only dependencies (@vitejs/plugin-react@^5for Vite 7 compatibility,react,react-dom,vite).packages/deck-engine/demo/— a small Vite app (index.html,vite.config.js,deck.config.js,src/main.jsx,src/App.jsx,src/index.css) that renders the bundled generic slides throughdeckPlugin+ the React plugin, mirroring the proven scaffold setup. This fixed a black screen caused by the engine.jsxfiles being served raw without the React/deck Vite plugins..gitignore— ignore Vite's.vite/dev cache..vscode/mcp.json— add the GitHub MCP server config.Notes
demo/is not part of the package'sfilesallowlist, so it is excluded from the published npm package (verified withnpm pack --dry-run). No version bump is needed — the published package behavior is unchanged.http://localhost:5173/and the engine slide JSX transforms correctly (no raw JSX served).Related
Onboarding follow-up tracked in #39.