Minor bugs in server/swap function processBlock#3587
Open
jholdstock wants to merge 2 commits intodecred:masterfrom
Open
Minor bugs in server/swap function processBlock#3587jholdstock wants to merge 2 commits intodecred:masterfrom
jholdstock wants to merge 2 commits intodecred:masterfrom
Conversation
It seemed that return was being used instead of continue mistakenly, which could lead to situations where the loop incorrectly exits early and not all matches are evaluated.
Using defer to unlock the mutex means that the mutex can be locked repeatedly during the loop and only unlocked when the function returns, rather than being unlocked at the end of the current loop iteration. This can lead to the mutex being held for longer than required.
jholdstock
force-pushed
the
processBlock-bugs
branch
from
33d3832 to
7be48b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.