fix: DH-21616: Databar overrides text color when using format prop#1323
Merged
mofojed merged 4 commits intodeephaven:mainfrom Apr 2, 2026
Conversation
|
ui docs preview (Available for 14 days) |
gzh2003
force-pushed
the
DH-21616-databar-overrides-text-color-when-using-format-prop
branch
from
1d090d9 to
efba92c
Compare
|
ui docs preview (Available for 14 days) |
gzh2003
changed the title
|
ui docs preview (Available for 14 days) |
1 similar comment
|
ui docs preview (Available for 14 days) |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DH-21616 by ensuring databar cell text color respects explicit formatting rather than inheriting the bar color.
Changes:
- Introduces
textColorresolution that prefers formatted text color when present. - Refactors databar color selection into
barColorand derives a default text color for gradients/non-gradients.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mofojed
previously approved these changes
Mar 26, 2026
mofojed
pushed a commit
to deephaven/web-client-ui
that referenced
this pull request
Mar 31, 2026
…2640) For DH-21616. Databar cells were using the databar bar color for both the bar and the text, ignoring any explicit text color set via formatting. Companion PR: deephaven/deephaven-plugins#1323
gzh2003
force-pushed
the
DH-21616-databar-overrides-text-color-when-using-format-prop
branch
from
d4f14d4 to
a9b8866
Compare
|
ui docs preview (Available for 14 days) |
mofojed
approved these changes
Apr 2, 2026
mofojed
reviewed
Apr 2, 2026
Comment on lines
+427
to
+428
| // @ts-expect-error TODO: bump web version | ||
| textColor, |
Member
There was a problem hiding this comment.
We should bump the web version for this... I'll merge it for now though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DH-21616. Databar cells were using the databar bar color for both the bar and the text, ignoring any explicit text color set via formatting.
Companion PR: deephaven/web-client-ui#2640
TODO: