feat: DH-21757: WidgetPlugin support in deephaven.ui#1326
Draft
mofojed wants to merge 15 commits intodeephaven:mainfrom
Draft
feat: DH-21757: WidgetPlugin support in deephaven.ui#1326mofojed wants to merge 15 commits intodeephaven:mainfrom
mofojed wants to merge 15 commits intodeephaven:mainfrom
Conversation
|
ui docs preview (Available for 14 days) |
mofojed
force-pushed
the
DH-21757-resolve-fixes
branch
from
c2c29c8 to
aa7c200
Compare
|
ui docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
1 similar comment
|
plotly-express docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
mofojed
force-pushed
the
DH-21757-resolve-fixes
branch
from
24d99fc to
f235a92
Compare
|
ui docs preview (Available for 14 days) |
- Needs deephaven/web-client-ui#2648 - WidgetPlugin just registers directly - Allows for nested ui.resolve deephaven.ui components - Still maintain DashboardPlugin to handle legacy behaviour - Works with the ui_home_screen, nested dashboards, etc - Styling a little bit different (ui.panel is automatically wrapped in a nested dashboard rather than opening up panels in the existing dashboard like before) - Dashboard now has a `show_headers` option that can be set to False to not show headers on a dashboard. Useful if you're doing a homescreen type dashboard
- Add moduleNameMapper in jest.config.cjs to resolve React 18 from the plugin's local node_modules, fixing dual-React-instance errors - Mock usePersistentState in @deephaven/plugin mock to avoid FiberProvider dependency in tests - Update DocumentHandler test to reflect new behavior where non-layout children are rendered directly without ReactPanel wrapping
mofojed
force-pushed
the
DH-21757-resolve-fixes
branch
from
f235a92 to
d6cfcab
Compare
|
ui docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
This reverts commit 74b7f3c.
…peer deps" This reverts commit d6cfcab.
The UI plugin uses React 18 / @types/react@18 while the root workspace uses React 17 / @types/react@17. When root tsc type-checks UI plugin files, dependencies at root node_modules resolve react to @types/react@17, causing type mismatch errors. Excluding the UI plugin from root tsc resolves this. The UI plugin still gets type checking via Jest.
|
ui docs preview (Available for 14 days) |
The root tsconfig.json excludes ui plugin files to avoid React type conflicts during tsc. ESLint needs those files included for type-aware linting, so point it to a tsconfig.eslint.json that re-includes them.
|
ui docs preview (Available for 14 days) |
|
ui docs preview (Available for 14 days) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show_headersoption that can be set to False to not show headers on a dashboard. Useful if you're doing a homescreen type dashboard