media: phytium: update phytium media controller driver support to 6.6.0.4

[wangchenlu2236]

This patches updates the support for phytium media controller driver.

1.media:phytium-jpeg: Redesign the feature of diplaying 'No Signal' on KVM
2.media: phytium-jpeg: Restricted adaptation platform for jpeg driver
3.media: phytium-jpeg: Reduce switch resolution latency

Summary by Sourcery

Improve Phytium JPEG media controller handling of input signal and host power state during resolution detection and switching.

Bug Fixes:

• Fix incorrect reporting of input signal status when the host is powered off or there is no signal on KVM.

Enhancements:

• Introduce a buffer-based marker and state flag to track host power and signal presence for more accurate resolution detection.
• Reduce resolution change delay to lower latency when switching resolutions.
• Initialize and restore JPEG controller signal state during driver init and resolution work to ensure consistent behavior across power and resolution changes.

[sourcery-ai]

Reviewer's Guide

Updates the Phytium JPEG media controller driver’s signal-detection and resolution-change handling by using a dedicated buffer register as a host power/signal state flag, adding host power-off tracking, and reducing resolution change latency, while removing an unnecessary power-off delay and performing small cleanups.

Sequence diagram for updated signal and resolution detection in Phytium JPEG driver

sequenceDiagram
    participant resolution_work as phytium_jpeg_resolution_work
    participant jpeg_dev as phytium_jpeg_dev
    participant BUF_LAST_reg as BUF_LIST_INDEX_ADDR_VB_BUF_LAST

    resolution_work->>jpeg_dev: phytium_jpeg_init_regs(jpeg_dev)
    resolution_work->>BUF_LAST_reg: phytium_jpeg_write(jpeg_dev, BUF_LIST_INDEX_ADDR(VB_BUF_LAST), HAVE_SIGNAL)
    resolution_work->>jpeg_dev: phytium_jpeg_get_resolution(jpeg_dev)

    activate jpeg_dev
    jpeg_dev->>BUF_LAST_reg: phytium_jpeg_read(jpeg_dev, BUF_LIST_INDEX_ADDR(VB_BUF_LAST))
    Note over jpeg_dev,BUF_LAST_reg: input_signal read from VB_BUF_LAST

    alt [input_signal == HOST_POWER_OFF]
        jpeg_dev-->jpeg_dev: once_poweroff = true
    else [jpeg_dev->once_poweroff == false]
        jpeg_dev->>BUF_LAST_reg: phytium_jpeg_write(jpeg_dev, BUF_LIST_INDEX_ADDR(VB_BUF_LAST), HAVE_SIGNAL)
        jpeg_dev-->jpeg_dev: v4l2_input_status may be cleared
    else [input_signal == HOST_POWER_ON]
        jpeg_dev-->jpeg_dev: v4l2_input_status = V4L2_IN_ST_NO_SIGNAL
    else [input_signal == HAVE_SIGNAL and width * height != 0]
        jpeg_dev-->jpeg_dev: detected_timings.width/height updated
        jpeg_dev-->jpeg_dev: v4l2_input_status = 0
    end
    deactivate jpeg_dev

    %% Query path using the same flag
    participant file as file
    file->>jpeg_dev: phytium_jpeg_query_dv_timings(file, priv, timings)
    activate jpeg_dev
    jpeg_dev->>BUF_LAST_reg: phytium_jpeg_read(jpeg_dev, BUF_LIST_INDEX_ADDR(VB_BUF_LAST))
    alt [input_signal != HAVE_SIGNAL]
        jpeg_dev-->jpeg_dev: v4l2_input_status = V4L2_IN_ST_NO_SIGNAL
    end
    jpeg_dev-->file: return (v4l2_input_status ? -ENOLINK : 0)
    deactivate jpeg_dev

Loading

File-Level Changes

Change	Details	Files
Redesigned signal/no-signal detection using a dedicated buffer index register to track host power state and KVM signal presence.	Introduce VB_BUF_LAST index and magic values HAVE_SIGNAL, HOST_POWER_ON, HOST_POWER_OFF to encode host/signal state in the buffer_list_address register. Initialize the BUF_LIST_INDEX_ADDR(VB_BUF_LAST) register to HAVE_SIGNAL during JPEG init and expand dst_addrs to accommodate VB_BUF_LAST. Add a once_poweroff boolean flag to the device state to track whether the host has been powered off since driver start. Update phytium_jpeg_get_resolution to read/write the new power-state flag, distinguish host-power-off from KVM no-signal cases, and only clear v4l2_input_status when valid signal/resolution is present. Change phytium_jpeg_query_dv_timings to base V4L2_IN_ST_NO_SIGNAL on the power-state flag instead of directly on source width/height.	drivers/media/platform/phytium/phytium_jpeg_core.c drivers/media/platform/phytium/phytium_jpeg_core.h
Adjusted resolution-change handling to be faster and to restore signal state during resolution switching.	Reduce RESOLUTION_CHANGE_DELAY from 250 ms to 150 ms to decrease resolution switch latency. In phytium_jpeg_resolution_work, restore BUF_LIST_INDEX_ADDR(VB_BUF_LAST) to HAVE_SIGNAL and reset once_poweroff before re-detecting resolution, assuming the host remains powered during a resolution switch. Slightly refine resolution-change logging message punctuation for consistency.	drivers/media/platform/phytium/phytium_jpeg_core.c drivers/media/platform/phytium/phytium_jpeg_core.h
Simplified power-off handling and tidied up minor code style issues.	Remove the fixed 50 ms mdelay from phytium_jpeg_off, relying on other mechanisms for safe power-down. Align arguments in devm_request_irq call to match kernel coding style. Initialize v4l2_input_status and once_poweroff during video setup to known default values.	drivers/media/platform/phytium/phytium_jpeg_core.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

Hi @wangchenlu2236. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Copilot]

Pull request overview

Updates the Phytium JPEG media controller driver to better detect host power state and signal presence on KVM, reduce resolution switch latency, and restrict the driver to Phytium platforms.

Changes:

• Use the last buffer-list address register as a marker to distinguish host-power-off, host-power-on/no-signal, and have-signal states; updates phytium_jpeg_get_resolution and phytium_jpeg_query_dv_timings accordingly.
• Reduce RESOLUTION_CHANGE_DELAY from 250ms to 150ms and drop the 50ms delay in phytium_jpeg_off.
• Add ARCH_PHYTIUM dependency in Kconfig.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
drivers/media/platform/phytium/phytium_jpeg_core.h	New marker macros (HAVE_SIGNAL/HOST_POWER_ON/OFF, VB_BUF_LAST), reduced resolution change delay, new once_poweroff flag
drivers/media/platform/phytium/phytium_jpeg_core.c	Power/signal detection via buffer-list register; init/restore signal marker; remove mdelay in jpeg_off
drivers/media/platform/phytium/Kconfig	Restrict driver build to ARCH_PHYTIUM

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new once_poweroff state is read/modified from both the resolution workqueue and the resolution/query paths; consider whether this needs explicit locking or atomic access to avoid races between host power transitions and signal detection.
• Using BUF_LIST_INDEX_ADDR(VB_BUF_LAST) as an out-of-band host power/signal marker is subtle; it may be worth centralizing the marker read/write logic in small helper functions so future changes don’t accidentally reuse that buffer index for data.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `once_poweroff` state is read/modified from both the resolution workqueue and the resolution/query paths; consider whether this needs explicit locking or atomic access to avoid races between host power transitions and signal detection.
- Using `BUF_LIST_INDEX_ADDR(VB_BUF_LAST)` as an out-of-band host power/signal marker is subtle; it may be worth centralizing the marker read/write logic in small helper functions so future changes don’t accidentally reuse that buffer index for data.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Avenger-285714]

/ok-to-test

[Avenger-285714]

/approve

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [Avenger-285714]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment