fix: cosmos3 worker.py /opt/app path + CodeQL except:pass (follow-up to #14)#19
Merged
Merged
Conversation
Two post-merge follow-ups from the prod rollout: - Dockerfile: COPY worker.py to /opt/app/worker.py + WORKDIR /opt/app. MM2's dynamo deployment runs 'python3 worker.py' with workingDir=/opt/app, so the worker MUST be there — the prior /workspace location made every prod pod crash-loop (python3: can't open /opt/app/worker.py). This is the fix behind the fw-v3 rebuild that's now serving prod. - worker.py: replace 'except ValueError: pass' in Cosmos3VideoRequest.resolve() with a log.warning (GitHub Advanced Security / CodeQL empty-except finding). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Johan-de-R
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge follow-up to #14, from the prod rollout.
worker.pyat/opt/app+WORKDIR /opt/app. MM2's dynamo deployment runspython3 worker.pywithworkingDir=/opt/app; the prior/workspacelocation made every prod pod fail (python3: can't open '/opt/app/worker.py'). This is the fix behind thefw-v3image now serving prod.except ValueError: passinCosmos3VideoRequest.resolve()with alog.warning(GitHub Advanced Security / CodeQL empty-except finding).Prod Cosmos3-Nano is live on
fw-v3/ B200 / checkpointfea6e03, verified end-to-end (clean 720p through the prod API).🤖 Generated with Claude Code