Fix: loose the threshold of the exx-nspin4-sym test case - #7715
Merged
Conversation
|
Would suggest to open an issue to track this problem; it should be finally fixed in the future regardless. |
Collaborator
I agree. @maki49 |
mohanchen
approved these changes
Jul 31, 2026
mohanchen
added
Refactor
Collaborator
|
Be careful, the bug may still exist. |
mohanchen
enabled auto-merge (squash)
July 31, 2026 04:31
mohanchen
disabled auto-merge
July 31, 2026 04:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case added in #7692 has randomness due to MPI + LibRI + Pathologically small parameter for testing efficiency (ecutwfc 5, etc. ). Other EXX cases unrelated to #7692 also suffer from this randomness. We now have no idea but to enlarge the error threshold.
Here's a detailed document to explain the randomness (generated by Claude):
EXX随机性：MPI 归约不可复现——机制拆解.md