feat: add BSE module - #7718
Open
Fisherd99 wants to merge 2 commits into
Open
Conversation
2. feat: add ExcitonPlotter 3. add input parameter `rpa_outdir` and `rpa_out_vel`
mohanchen
reviewed
Jul 31, 2026
Collaborator
There was a problem hiding this comment.
please put any 'esolver' into source_esolver
Author
There was a problem hiding this comment.
The ESolver_BSE class is a derived class of ESolverLR. Shall I move both of them?
Collaborator
There was a problem hiding this comment.
That would be better, you could discuss this with @maki49
|
Just a note: the current code is not well encapsulated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATTENTION: BSE module depends on LibRI#11 Implement CVC algorithm and enhance LR class abacusmodeling/LibRI#11
rpa_outdirandrpa_out_velfor Output files are not in the correct directories #7661Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.Not yet. The BSE module depends on LibRPA output files for reading. I don't know whether we can upload these files.
source/changes.Linked Issue
Fix #7661
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes