Fix(dftu-pw): fix DFT+U for PW basis (nspin=1/2/4) and occupation mat… - #7733
Open
dyzheng wants to merge 2 commits into
Open
Fix(dftu-pw): fix DFT+U for PW basis (nspin=1/2/4) and occupation mat…#7733dyzheng wants to merge 2 commits into
dyzheng wants to merge 2 commits into
Conversation
…rix mixing - Relax DFT+U nspin validation to support nspin=1/2/4 for PW basis - Encapsulate Plus_U with typed accessors (get/set_locale, get_orbital_corr, get_hubbard_u, is_locale_initialized, mark_locale_dirty, enable_mixing) - Rewrite cal_occ_pw for nspin=1/2/4 with correct becp indexing - Add DFT+U occupation matrix mixing via Broyden method in Charge_Mixing - Fix DFT+U locale double-counting when kpar>1 - Fix spin-channel selection: use isk[ik] instead of ik>=nk/2 in cal_occ_pw - Extract setup_pw_dftu_indices() from cal_ps_dftu - Propagate ld_psi for correct GEMM strides when ngk[ik] < npwx - Restructure eff_pot_pw layout: nspin=2 uses split spin_up|spin_down - Add get_eff_pot_pw_spin(isk) for nspin-aware access - Add becp_ready caching in OnsiteProjector - Update dftu_lcao.cpp for new Plus_U accessor interface - Add unit tests for PW DFT+U (dftu_pw_test.cpp) - Update dftu_io.cpp to use new accessors and onsite.dm format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rix mixing
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes