Skip to content

Stop obsolete CI jobs on workflow cancellation #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tohtana wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Stop obsolete CI jobs on workflow cancellation #8034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aws-torch-latest-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
name: Unit Tests (Full)
needs: [check-changes]
if: |
always() &&
!cancelled() &&
(github.event_name == 'workflow_dispatch' || needs.check-changes.outputs.has_changes == 'true')
runs-on: [self-hosted, gpu-ci, gpu-l40s, l40s-4gpu, aws]
timeout-minutes: 180
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cpu-torch-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
unit-tests:
name: cpu-torch-latest / unit tests
needs: check-paths
if: always() && (needs.check-paths.result != 'success' || needs.check-paths.outputs.should_run == 'true')
if: ${{ !cancelled() && (needs.check-paths.result != 'success' || needs.check-paths.outputs.should_run == 'true') }}
runs-on: ubuntu-24.04

env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/modal-torch-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
runs-on: ubuntu-latest
needs: collect-tests

if: always() && (github.event_name == 'workflow_dispatch' || needs.collect-tests.result != 'success' || needs.collect-tests.outputs.deepspeed == 'true')
if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || needs.collect-tests.result != 'success' || needs.collect-tests.outputs.deepspeed == 'true') }}
steps:
- name: Fail if path filter failed
if: github.event_name != 'workflow_dispatch' && needs.collect-tests.result != 'success'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nv-pre-compile-ops.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
unit-tests:
name: nv-pre-compile-ops / precompile ops
needs: check-paths
if: always() && (needs.check-paths.result != 'success' || needs.check-paths.outputs.should_run == 'true')
if: ${{ !cancelled() && (needs.check-paths.result != 'success' || needs.check-paths.outputs.should_run == 'true') }}
runs-on: ubuntu-24.04
container:
image: nvidia/cuda:12.6.3-devel-ubuntu22.04
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
unit-tests:
name: python / install smoke (Python ${{ matrix.pyVersion }})
needs: check-paths
if: always()
if: ${{ !cancelled() }}
strategy:
matrix:
pyVersion: ["3.10", "3.11", "3.12"]
Expand Down
Loading