Skip to content

support opening on coordinates via URL's hash#9

Open
adbenitez wants to merge 2 commits into
mainfrom
adb/support-coordinates-via-hash
Open

support opening on coordinates via URL's hash#9
adbenitez wants to merge 2 commits into
mainfrom
adb/support-coordinates-via-hash

Conversation

@adbenitez
Copy link
Copy Markdown
Member

@adbenitez adbenitez commented Apr 30, 2026

this will allow clients to support opening map on POI when user clicks POI messages IN THE CHAT (messages sent from inside the map, the ones that have the location marker in the message bubble)

@adbenitez adbenitez requested review from nicodh and r10s April 30, 2026 15:44
@adbenitez adbenitez self-assigned this Apr 30, 2026
@adbenitez
Copy link
Copy Markdown
Member Author

once this is in, the next problem is that core doesn't provide the POI coordinates to the UI/clients, in ArcaneChat I already implemented this in core and I am using a maps app with this patch,

if even I managed to add it to core probably @r10s can do it, here you can see my changes in core: ArcaneChat/core@ba15bba

NOTE: merging this PR doesn't depend on having this ready in core and the UIs

Copy link
Copy Markdown
Member

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, except the input validation of the provided hash values

@adbenitez
Copy link
Copy Markdown
Member Author

please remember I am not really a web developer, could you explain more precisely what do you mean, or feel free to push/tweak this PR directly as well!

@nicodh
Copy link
Copy Markdown
Member

nicodh commented May 6, 2026

could you explain more precisely what do you mean

I added a suggestion so all you need to do is click the commit suggestion button :-)

Ah it didn't save for some reason:

image

@nicodh
Copy link
Copy Markdown
Member

nicodh commented May 6, 2026

I pushed a commit myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants