Fix live indexing and Docker runtime permissions#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211.
This handles a few related indexing/runtime problems from that report: Docker can now run the app services with configurable
PUID/PGID, live sources no longer crash if a file disappears after scanning, Markdown with broken frontmatter still indexes the body, and nested metadata is serialized safely before sending documents to Meilisearch.Also caught one extra container issue during smoke testing: managed Meilisearch needs to start from a writable directory after the runtime UID changes, so the generated supervisord config now runs it from
/app/meili_data.Verified with backend tests and a targeted smoke using group-readable source mounts, malformed Markdown, datetime frontmatter, and a file deleted during indexing.