Fix RTT truncation, min/max initialization, and timeout packet counting.#48
Open
leviskualo wants to merge 1 commit into
Open
Fix RTT truncation, min/max initialization, and timeout packet counting.#48leviskualo wants to merge 1 commit into
leviskualo wants to merge 1 commit into
Conversation
Removed outdated comments and TODOs from the script, added new parameters for audible ping and time printing, and improved argument parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The int($4) to $4 + 0 fix (prevents sub-millisecond RTTs from being truncated to 0ms).
The first_received boolean flag (fixes the bug where min_rtt and max_rtt stay stuck at 0 if the first packet is dropped).
The while ( last_seq < seq ) loop in the macOS timeout branch (ensures multiple dropped packets are counted correctly).
The stty size < /dev/tty fix (makes terminal size detection work on Linux, rather than silently failing with the macOS-only -f flag).