fix: handle broken pipe gracefully instead of panicking#32946
Open
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Open
fix: handle broken pipe gracefully instead of panicking#32946bartlomieju wants to merge 1 commit intodenoland:mainfrom
bartlomieju wants to merge 1 commit intodenoland:mainfrom
Conversation
When stdout is piped to a command that exits early (e.g. `deno info | head`), println! panics from Rust's stdio module. Instead of showing a scary "Deno has panicked" message, detect this via the panic location and exit silently with code 141 (128 + SIGPIPE) on Unix or 1 on Windows. This covers all 68+ println! callsites in the CLI without needing to modify each one individually or toggle SIGPIPE signal handlers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When stdout is piped to a command that exits early (e.g.
deno info | head,deno test | jq),println!panics from Rust's stdio module, producing ascary "Deno has panicked" message.
This adds a check in the existing panic hook that detects panics originating
from Rust's
io/stdio.rsmodule and exits silently with code 141(128 + SIGPIPE) on Unix or 1 on Windows, matching standard Unix CLI behavior.
This covers all 68+
println!callsites in the CLI without needing to:Supersedes #28383
Closes #28338
Closes #25258
Closes #24529
Closes #15767
Closes #15045
Test plan
Tested all reported scenarios on macOS:
🤖 Generated with Claude Code