fix(lsp): check completionProvider key existence, not emptiness - #5157
Open
jniklasson wants to merge 1 commit into
Open
fix(lsp): check completionProvider key existence, not emptiness#5157jniklasson wants to merge 1 commit into
jniklasson wants to merge 1 commit into
Conversation
completionProvider: {} is valid per the LSP spec (means completion
enabled with default options). The old !empty() check incorrectly
rejected empty objects, causing ALE to silently disable completion
for servers that send completionProvider: {}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completionProvider: {} is valid per the LSP spec (means completion enabled with default options). The old !empty() check incorrectly rejected empty objects, causing ALE to silently disable completion for servers that send completionProvider: {}.
This change fixes auto completion for openscad-lsp added in #5156.