Skip to content

A "kiosk" session for AstroArch#243

Open
sc74 wants to merge 28 commits intodevDucks:mainfrom
sc74:kiosk
Open

A "kiosk" session for AstroArch#243
sc74 wants to merge 28 commits intodevDucks:mainfrom
sc74:kiosk

Conversation

@sc74
Copy link
Copy Markdown
Contributor

@sc74 sc74 commented Mar 16, 2026

No description provided.

Comment thread scripts/backup-astroarch.sh Outdated
Comment thread scripts/backup-astroarch.sh Outdated
Comment thread scripts/restore-astroarch.sh Outdated
Comment thread scripts/restore-astroarch.sh Outdated
Comment thread configs/startwm.sh
local DEST="$1"
# Supprime le dossier corrompu (nécessite sudo car rsync préserve les permissions root)
if [ -d "$DEST" ]; then
sudo rm -rf "$DEST"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may nuke the whole system for the user, and this is bash. So I have already nightmares in front of my eyes. Let's try to be defensive at least by checking [[ -z $DEST ]] || [[$DEST == "/" ]]; return 1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done by deleting the folder only if its name is “backup” and it is not in the root directory

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do you exactly check what's the folder is?

Copy link
Copy Markdown
Contributor Author

@sc74 sc74 Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backup is only deleted if the user cancels the command. There is no validation of the contents of the backup folder in restore-astroarch.sh. The system relies on the .backup_dest file, or if that file does not exist on the user to select the folder from the directory tree in a dialog box. A warning message indicates that the system will be overwritten from the specified folder and asks the user to confirm

Comment thread scripts/astroarch-config-kiosk.sh Outdated
Comment thread scripts/restore-astroarch.sh Outdated
Comment thread configs/kiosk/.xinitrc Outdated
Comment thread scripts/create_ap.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants