build(deps): update intervention/image requirement from ^3.0 to ^4.0#1781
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Open
build(deps): update intervention/image requirement from ^3.0 to ^4.0#1781dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Updates the requirements on [intervention/image](https://github.com/Intervention/image) to permit the latest version. - [Release notes](https://github.com/Intervention/image/releases) - [Commits](Intervention/image@3.0.0...4.0.0) --- updated-dependencies: - dependency-name: intervention/image dependency-version: 4.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
| "illuminate/database": "^12.0", | ||
| "illuminate/filesystem": "^12.0", | ||
| "intervention/image": "^3.0", | ||
| "intervention/image": "^4.0", |
There was a problem hiding this comment.
CRITICAL: Major version upgrade with breaking API changes
Intervention Image v4 has significant breaking changes that will cause runtime errors:
-
Static factory methods removed:
ImageManager::gd()andImageManager::imagick()no longer exist- Used in:
lib/common.php:560,src/Models/Upload.php:429 - Replacement:
new ImageManager('gd')orImageManager::withDriver('gd')
- Used in:
-
read()method removed: Replaced withdecode()- Used in: 8+ locations across the codebase
- Replacement:
$manager->decode($source)or$manager->decodePath($path)
All image processing will fail until code is updated to v4 API.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Do NOT merge without code updates Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Migration Guidev3 → v4 API Changes Required:1. ImageManager instantiation: // v3 (old)
ImageManager::gd()
ImageManager::imagick()
ImageManager::gd(autoOrientation: true)
// v4 (new)
new ImageManager('gd')
new ImageManager('imagick')
new ImageManager('gd', autoOrientation: true)2. Reading images: // v3 (old)
$manager->read($filepath)
$manager->read(base64_decode($data))
// v4 (new)
$manager->decode($filepath)
$manager->decodeBase64($data)Files Reviewed (1 file)
Reviewed by glm-5-20260211 · 346,285 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on intervention/image to permit the latest version.
Release notes
Sourced from intervention/image's releases.
Commits
66865f1Merge branch 'next' into develop518b529Edit readme8127043Change and rename argument opacity of ImageInterface::insert()764fa07Edit doc blocksab6b54eEdit exception message1125b5eAdd string variants for Alignment::classee75468Change type of image in ImageInterface::insert()e46633cFix intervention/gif to v5fd32c07Add Size::create()252e17cRemove todosDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)