Skip to content

fix: change visual if columns, no render hard columns #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kulikp1 wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −21
Open

fix: change visual if columns, no render hard columns #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad5398
fix: change visual if columns, no render hard columns
kulikp1 Jun 17, 2026
a9ae756
chore:test
kulikp1 Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions custom/InlineCreateForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<template>
<template v-if="isCreating">
<td class="px-4 py-2"></td>
<td v-for="column in allVisibleColumns" :key="column.name" class="px-2 md:px-3 lg:px-6 py-2">
<div v-if="isEditableColumn(column)" class="flex gap-2">
<td v-for="column in allVisibleColumns" :key="column.name" class="af-ic-cell px-2 py-2">
<div v-if="isEditableColumn(column)" class="flex gap-1 items-start">
<ColumnValueInputWrapper
ref="input"
class="min-w-24"
class="w-full min-w-0"
:source="'create'"
:column="column"
:currentValues="formData"
Expand All @@ -15,7 +15,14 @@
:setCurrentValue="setCurrentValue"
@update:unmasked="handleUnmasked"
/>
<div v-if="column.required?.create" class="pt-3" ><IconExclamationCircleSolid class="w-4 h-4 opacity-50" :title="t('This field is required')" /></div>
<div v-if="column.required?.create" class="pt-3 shrink-0" ><IconExclamationCircleSolid class="w-4 h-4 opacity-50" :title="t('This field is required')" /></div>
</div>
<div
v-else-if="hasCustomCreateComponent(column)"
class="text-xs text-gray-400 dark:text-gray-500 italic"
:title="t('Editable after creation')"
>
{{ t('After creation') }}
</div>
<div v-else></div>
</td>
Expand Down Expand Up @@ -80,23 +87,16 @@
unmasked.value[columnName] = !unmasked.value[columnName];
}

const allVisibleColumns = computed(() => {
const columnsMap = new Map();

coreStore.resource.columns.filter(c => c.showIn?.list).forEach(column => {
columnsMap.set(column.label, column);
});

visibleColumns.value.forEach(column => {
columnsMap.set(column.label, column);
});

return Array.from(columnsMap.values());
});
const allVisibleColumns = computed(() =>
coreStore.resource.columns.filter(c => c.showIn?.list)
);

function hasCustomCreateComponent(column) {
return !!column.components?.create;
}

// Function to check if a column should be editable
function isEditableColumn(column) {
return !column.backendOnly && column.showIn?.create !== false && !column.primaryKey;
return !column.backendOnly && column.showIn?.create !== false && !column.primaryKey && !hasCustomCreateComponent(column);
}

const columnOptions = computedAsync(async () => {
Expand Down Expand Up @@ -218,4 +218,17 @@
saving.value = false;
}
}
</script>
</script>

<style scoped>
.af-ic-cell :deep(input),
.af-ic-cell :deep(textarea),
.af-ic-cell :deep(.w-40) {
width: 100% !important;
min-width: 0 !important;
}
.af-ic-cell :deep(textarea) {
min-height: 2.5rem;
max-height: 4rem;
}
</style>
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default class InlineCreatePlugin extends AdminForthPlugin {
super(options, import.meta.url);
this.options = options;
}

async modifyResourceConfig(adminforth: IAdminForth, resourceConfig: AdminForthResource) {
super.modifyResourceConfig(adminforth, resourceConfig);

Expand Down