feat(messages): split MessagesView, move search/actions to nav, reuse @antfu/design#135
Merged
Merged
Conversation
…euse @antfu/design
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reorganizes the messages plugin's client surface without changing behavior.
MessagesView.vueapart. The 464-line monolith becomes a thin orchestrator; filter/search/sort state moves into auseMessageFilterscomposable (a shared reactive façade), and the view splits intoMessageFilterBar,MessageList,MessageDetail, plus a nav-barMessageToolbarActions.App.vuenow owns the filter state and renders the search field and the sort / reset / dismiss-filtered / dismiss-all actions in the sharedLayoutToolbar; the body holds only the filter bar, list, and detail.@antfu/designcomponents:FormSearchField,ActionButton/ActionIconButton,DisplayBadge,FeedbackEmptyState,FeedbackSpinner, andLayoutSeparator(adds thefloating-vuedep + base CSS for tooltips, mirroring the inspect plugin).HashBadgein favor ofDisplayBadge(which hashes its own dark-mode-aware color), dropping the bespoke hash helper.src/types.ts, a pure re-export of@devframes/hub/types. Internal imports point at the hub directly; the public type re-exports on the main and/cliententries are preserved. The redundant./typessubpath export is dropped frompackage.json,alias.ts,tsconfig.base.json,tsdown.config.ts, and its API snapshot.Verification
pnpm build,pnpm typecheck,pnpm lint, and the messages plugin's vitest suite all pass. E2E skipped.Note:
tests/exports.test.tsshows pre-existing repo-wide tsnapi snapshot drift (the committed snapshots use the oldexport { X }format that installed tsnapi@1.2.0 no longer emits; untouched packages likeplugins/terminalsfail identically). Left those snapshots untouched to avoid unrelated churn; only the genuinely obsoletetypessnapshot was removed.This PR was created with the help of an agent.