Hotfix (v1.4.1): badge Sites akurat — flush config sebelum baca status#12
Merged
Conversation
…s akurat sites_status (Rust) membaca config.json dari disk, sedangkan mutasi sites (add/edit/delete/toggle) memakai scheduleSave() berdebounce 500ms. Akibatnya refreshSitesStatus() bisa membaca config lama -> badge tetap "Sinkron" walau ada perubahan, dan openApply() bisa mengira in-sync (Apply seakan no-op). Flush pending debounce via saveImmediate() sebelum baca status. Satu titik di refreshSitesStatus() menutup semua konsumen (4 handler + openApply) sekaligus. devhardiyanto
devhardiyanto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Perbaiki badge status di tab Sites yang tidak berubah jadi "Ada perubahan belum diterapkan" tepat setelah Tambah domain (baru muncul setelah Edit→Simpan).
Why
sites_status(Rust) membacaconfig.jsondari disk, sedangkan mutasi sites (add/edit/delete/toggle) memakaischeduleSave()berdebounce 500ms.refreshSitesStatus()sering membaca config lama sebelum debounce ter-flush → badge tetap "Sinkron". Bukan sekadar kosmetik:openApply()juga bisa mengira in-sync → Apply seakan no-op bila diklik <500ms setelah mutasi.How
Flush pending debounce via
saveImmediate()(sudah ada, dipakai pola sama di toggle→tray) di dalamrefreshSitesStatus(). Satu titik menutup semua konsumen (4 handler +openApply). Tradeoff: 1config_writeidempoten ekstra per refresh — negligible.Changes
src/views/Settings.vue:refreshSitesStatus()await saveImmediate()sebelum bacasites_status; destructuresaveImmediatedariuseConfig.1.4.0→1.4.1(package.json, tauri.conf.json, Cargo.toml, Cargo.lock).Testing
Manual: Add domain → badge langsung "Ada perubahan belum diterapkan" tanpa perlu Edit. Verifikasi terpisah cancel-UAC & self-clean (Sprint 11) sudah PASS via inspeksi backup/hosts.
devhardiyanto