fix: onboarding Linux/macOS — resolusi PATH GUI-launched app + instruksi platform-aware (v1.4.3)#13
Merged
Merged
Conversation
AppImage/.app yang dilaunch dari desktop launcher tidak mewarisi PATH shell interaktif, sehingga tool yang di-install via shell rc (fnm, phpvm) tak terdeteksi walau sudah terpasang. Tambah resolusi PATH via login-interactive shell (timeout 5s, cached) + merge dir install umum, diterapkan di silent_command. Route probe_version + docker spawn (services, stats) lewat silent_command agar konsisten. devhardiyanto
Command get_platform() mengembalikan "windows"/"macos"/"linux" via cfg, dipakai frontend untuk menampilkan instruksi prasyarat sesuai OS. devhardiyanto
Instruksi prasyarat sebelumnya hard-coded Windows. Sekarang ambil OS via get_platform: perintah install fnm per-OS (winget/brew/curl), actions Docker per-OS (Linux=Docker Engine + post-install, macOS=Desktop), dan pada Linux tampilkan instruksi `systemctl start docker` langsung (sembunyikan tombol Start Docker yang tak berlaku). devhardiyanto
Patch onboarding Linux/macOS: resolusi PATH GUI-launched app + instruksi prasyarat platform-aware. devhardiyanto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Perbaiki onboarding di Linux & macOS: tool yang sudah terpasang kini terdeteksi, dan instruksi prasyarat menyesuaikan OS. Bump versi → 1.4.3.
Why
Servel Windows-first. Di Linux/macOS onboarding bermasalah:
~/.local/bin, dir fnm/phpvm) tak ketemu saat di-spawn.winget install Schniz.fnm(Windows-only) untuk semua OS.systemctl.Root cause PATH identik di Linux & macOS, jadi satu patch menutup keduanya.
How
util.rs):silent_commandnon-Windows meng-inject PATH hasil resolusi login-interactive shell ($SHELL -lic, timeout 5s, cached viaOnceLock) ∪ PATH proses ∪ dir install umum. Semua spawn tool eksternal (phpvm, fnm, docker diprereq/services/stats) lewat jalur ini.get_platformcommand (prereq.rs): kembalikan"windows"/"macos"/"linux"untuk UI.Onboarding.vue): perintah install fnm per-OS (winget/brew/curl), actions Docker per-OS, dan pada Linux tampilkansystemctl start dockerlangsung (tombol Start Docker disembunyikan).Changes
src-tauri/src/commands/util.rs— helper resolusi PATH +silent_commandinject PATH (non-Windows).src-tauri/src/commands/prereq.rs—probe_versionviasilent_command; commandget_platform.src-tauri/src/commands/services.rs,stats.rs— docker spawn viasilent_command.src-tauri/src/lib.rs— registerget_platform.src/views/Onboarding.vue— instruksi prasyarat platform-aware.package.json,Cargo.toml,tauri.conf.json,Cargo.lock— v1.4.3.Testing
cargo check✓ ·vue-tsc --noEmit✓devhardiyanto