Skip to content

Commit e9842bf

Browse files
committed
fix: apply linter suggestions
1 parent b74a429 commit e9842bf

3 files changed

Lines changed: 11 additions & 17 deletions

File tree

src/Core/Deserialize/Resolve/CollectionChain.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
use ReflectionParameter;
1313

1414
use function Constructo\Cast\stringify;
15+
use function is_subclass_of;
1516

1617
class CollectionChain extends Chain
1718
{
@@ -21,20 +22,19 @@ class CollectionChain extends Chain
2122
public function resolve(ReflectionParameter $parameter, mixed $value): Value
2223
{
2324
$candidate = $this->detectCollectionName($parameter);
24-
$className = stringify($candidate);
25-
if (! $candidate || ! $value instanceof Collectable) {
25+
if ($candidate === null || ! $value instanceof Collectable) {
2626
return parent::resolve($parameter, $value);
2727
}
28-
return $this->resolveCollection($parameter, $className, $value);
28+
return $this->resolveCollection($parameter, $candidate, $value);
2929
}
3030

3131
/**
32-
* @param Collectable|class-string<Collectable> $className
32+
* @param class-string<Collectable> $className
3333
* @throws ReflectionException
3434
*/
3535
private function resolveCollection(
3636
ReflectionParameter $parameter,
37-
Collectable|string $className,
37+
string $className,
3838
Collectable $value
3939
): Value {
4040
$reflection = new ReflectionClass($className);

src/Core/Fake/Resolver/FromCollection.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44

55
namespace Constructo\Core\Fake\Resolver;
66

7+
use Constructo\Contract\Collectable;
78
use Constructo\Core\Fake\Resolver;
89
use Constructo\Support\Set;
910
use Constructo\Support\Value;
1011
use Constructo\Testing\MakeExtension;
1112
use Constructo\Testing\ManagedExtension;
12-
use Constructo\Type\Collection;
1313
use ReflectionClass;
1414
use ReflectionException;
1515
use ReflectionParameter;
@@ -25,14 +25,14 @@ final class FromCollection extends Resolver
2525
public function resolve(ReflectionParameter $parameter, Set $presets): ?Value
2626
{
2727
$collectionName = $this->detectCollectionName($parameter);
28-
if ($collectionName) {
29-
return $this->resolveCollection($collectionName);
28+
if ($collectionName === null) {
29+
return parent::resolve($parameter, $presets);
3030
}
31-
return parent::resolve($parameter, $presets);
31+
return $this->resolveCollection($collectionName);
3232
}
3333

3434
/**
35-
* @param class-string<Collection> $collectionName
35+
* @param class-string<Collectable> $collectionName
3636
* @throws ReflectionException
3737
*/
3838
private function resolveCollection(string $collectionName): Value

src/Core/Reflect/Resolver/Type/DependencyTypeHandler.php

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,7 @@ protected function resolveNamedType(ReflectionNamedType $parameter, Field $field
3030
*/
3131
private function resolveDynamicType(Field $field, string $source): void
3232
{
33-
if ($this->types === null) {
34-
$field->array();
35-
$field->setSource($source);
36-
return;
37-
}
38-
39-
$type = $this->types->get($source);
33+
$type = $this->types?->get($source);
4034
if (is_string($type)) {
4135
$field->{$type}();
4236
return;

0 commit comments

Comments
 (0)