chore: update makefile to require passing argument - BOS-3863#11
Open
dhumphries-sainsburys wants to merge 23 commits into
Open
chore: update makefile to require passing argument - BOS-3863#11dhumphries-sainsburys wants to merge 23 commits into
dhumphries-sainsburys wants to merge 23 commits into
Conversation
both of these unexpectedly caused whole ASG replacement when this was not desired
due to each.value being considered dynamic ("known after apply")
BOS-901 chore: Bump to allow terraform 1.0.X
BOS-1632 - chore: update kubeconfig to current apiversion
* chore: fix tflint issues as well * chore: change name of the cw logs group * chore: update aws provider version required to support log_group_class * fix: resolve tflint issues in aws_auth sub-module * fix: resolve tflint issues in node_groups sub-module * fix: resolve tflint issues in worker_groups sub-module * chore: add support for changing region as was not set at top level of module, although we try to pass it in from ekscluster * chore: comment out unused vars * chore: remove unused vars
* chore: add eks cluster authentication mode * chore: adding vars and updating Readme * chore: adding the default variable * chore: adding the default variable * chore: adding default bootstrap variable
Signed-off-by: daniel.humphries <daniel.humphries@sainsburys.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.