Skip to content

refactor(pro): rename Pro to Platform in login lock errors and agent docs - #1658

Merged
skevetter merged 1 commit into
mainfrom
refactor/rename-pro-lock-text-docs
Oct 22, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/rename-pro-lock-text-docs

Conversation

@skevetter

@skevetter skevetter commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • cmd/pro/login.go: login lock error text "Pro" -> "Platform" (2 lines).
  • Agent docs: .agents/skills/devsy/references/cli.md, .agents/skills/devsy/references/troubleshooting.md, hack/ci/agent-skill-evaluation.md: "Devsy Pro workspaces" / "Pro-only" -> "Platform".
  • Token-only. No comments added, no code paths or contracts changed.

Why

Finishes the user-visible Pro -> Platform text left after #1632 and #1649. Skipped files in open PRs (cmd/root.go in #1581/#1588, pkg/platform/client/client.go in #1588). Skipped the pro provider and fallbackProvider YAML in cmd/pro/login.go (~L322): persisted provider data, T3.

Tier

T1 (error text with no contract) plus docs. No CLI, flag, env, config, or provider-key change.

Validation

  • Before/after git grep -nP 'Pro login lock|Pro-only|Devsy Pro workspaces' on touched paths: 5 -> 0.
  • go build ./cmd/... ./pkg/...: ok
  • go test ./cmd/pro/...: ok
  • mise run cli:format: no diff
  • mise run cli:lint:ci: 0 issues
  • Repo-wide grep for old strings: no tests, e2e, or sites references.

CodeRabbit CLI

Failed: rate_limit (free OSS quota, ~9 min reset). Not retried. GitHub CodeRabbit review still gates.

Auto-merge

Eligible under rename T1: yes. Non-test changed lines: 10 (5 added, 5 removed) across 4 files. Caveat: auto-refactor step 2 forbids output-text changes; the login error text is T1 under the rename skill, so the coordinator should confirm.

Remaining

Summary by CodeRabbit

  • Documentation
    • Clarified that the workspace ping diagnostic applies to Devsy Platform workspaces, not Devsy Pro workspaces.
  • Bug Fixes
    • Updated login-lock error messages to refer to the Platform login lock.

@skevetter skevetter added the rename Loft/Pro rename label Oct 22, 2026
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 0977d96
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ada5cedcd9656138238cd87

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c86496e0-e67d-4b52-a226-539b9cd0092d
📥 Commits

Reviewing files that changed from the base of the PR and between ed43aa2 and 0977d96.

📒 Files selected for processing: 4
  • .agents/skills/devsy/references/cli.md
  • .agents/skills/devsy/references/troubleshooting.md
  • cmd/pro/login.go
  • hack/ci/agent-skill-evaluation.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The PR updates workspace ping references and login-lock error text to identify Devsy Platform instead of Devsy Pro. It also changes the workspace connection-failure evaluation criterion to specify a Platform-only ping.

Changes: Platform terminology updates

Layer / File(s) Summary
Update Pro references to Platform
cmd/pro/login.go, .agents/skills/devsy/references/cli.md, .agents/skills/devsy/references/troubleshooting.md, hack/ci/agent-skill-evaluation.md
Login-lock errors, workspace ping documentation, and the connection-failure criterion now use Platform terminology instead of Pro terminology.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Possibly related issues

  • Issue 1551 tracks the repo-wide Pro-to-Platform rename and includes the login-lock text and agent documentation updated here.
Merge Risk: ⚪ Minimal · up to 0977d

The PR is mergeable with no identified functional or operational risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately describes the terminology changes in the login lock errors and agent documentation.
Description check Passed The description is detailed and relevant. It explains the purpose, scope, exclusions, validation steps, and remaining work. It omits some template sections, such as the explicit type, AI assistance di…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description is detailed and relevant. It explains the purpose, scope, exclusions, validation steps, and remaining work. It omits some template sections, such as the explicit type, AI assistance disclosure, issue reference, and checklist, but the required change context is mostly complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 0977d96
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ada5cedec9d371511faefe0

@skevetter
skevetter marked this pull request as ready for review October 22, 2026 20:10
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@mergify

mergify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit 1d61e36 into main Oct 22, 2026
114 checks passed
@skevetter
skevetter deleted the refactor/rename-pro-lock-text-docs branch October 22, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant