You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The self-update e2e spec runs devsy update --dry-run, which calls the GitHub releases API. pkg/selfupdate/source.go authenticates only from GITHUB_TOKEN, but the e2e job exports GH_ACCESS_TOKEN, so the call is unauthenticated and hits the shared-IP rate limit (RATE_LIMITED in 0.15s on runs 39700556559 and 39388152441, both first-attempt failures on main).
The spec now forwards GH_ACCESS_TOKEN as GITHUB_TOKEN for its own process only, so other specs and the gh-forwarding fixture still see the environment unchanged.
Verified locally: valid token passes; GH_ACCESS_TOKEN=bogus fails with "401 Bad credentials", showing the token reaches the update client.
Summary by CodeRabbit
Tests
Updated the self-update dry-run test to handle an existing access token without changing other token settings.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a9f0040c-58f9-4619-9c42-86c289cc966d
📥 Commits
Reviewing files that changed from the base of the PR and between 2ed6d87 and 746bcb3.
📒 Files selected for processing: 1
e2e/tests/self/self.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The self-update dry-run test now copies a nonempty GH_ACCESS_TOKEN value to GITHUB_TOKEN. If GH_ACCESS_TOKEN is empty, the test leaves GITHUB_TOKEN unchanged.
Changes: Self-update token setup
Layer / File(s)
Summary
Configure the test token e2e/tests/self/self.go
When GH_ACCESS_TOKEN is nonempty, the test sets GITHUB_TOKEN to that value using Ginkgo’s test-scoped environment setter.
The self-update dry-run token setup is mergeable as reviewed.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description clearly explains the problem, the cause, the scope of the fix, and local verification. However, it omits the required template sections for issue tracking, change type, AI assistance, …
Complete the required pull request template. Add the Fixes or Refs line, select the change type, disclose AI assistance, document the e2e test suite and commands, complete the checklist, and include any applicable reviewer notes.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: authenticating the self-update dry-run to avoid GitHub rate limits. It follows the expected Conventional Commits format.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
Full details: Description check
Explanation
The description clearly explains the problem, the cause, the scope of the fix, and local verification. However, it omits the required template sections for issue tracking, change type, AI assistance, testing details, checklist items, and reviewer notes.
Resolution
Complete the required pull request template. Add the Fixes or Refs line, select the change type, disclose AI assistance, document the e2e test suite and commands, complete the checklist, and include any applicable reviewer notes.
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The self-update e2e spec runs
devsy update --dry-run, which calls the GitHub releases API.pkg/selfupdate/source.goauthenticates only fromGITHUB_TOKEN, but the e2e job exportsGH_ACCESS_TOKEN, so the call is unauthenticated and hits the shared-IP rate limit (RATE_LIMITEDin 0.15s on runs 39700556559 and 39388152441, both first-attempt failures on main).The spec now forwards
GH_ACCESS_TOKENasGITHUB_TOKENfor its own process only, so other specs and the gh-forwarding fixture still see the environment unchanged.Verified locally: valid token passes;
GH_ACCESS_TOKEN=bogusfails with "401 Bad credentials", showing the token reaches the update client.Summary by CodeRabbit