Skip to content

refactor(cmd): rename proutil package to cmdutil - #1672

Merged
skevetter merged 1 commit into
mainfrom
refactor/pro-rename-proutil-package
Oct 23, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/pro-rename-proutil-package

Conversation

@skevetter

@skevetter skevetter commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Rename Go package cmd/pro/proutil to cmd/pro/cmdutil (dir, proutil.go to cmdutil.go, proutil_test.go to cmdutil_test.go).
  • Update the package clause, package doc comment, and all 15 importers in cmd/pro/**: import path plus every proutil. qualifier.
  • Token-only: no behaviour change, no other renames, no new comments.

Why

proutil is an internal helper package named after the old "Pro" product. It is part of the Pro to Platform rename and precedes the cmd/pro to cmd/platform move.

Tier

T1: internal Go package. All importers are in this repo (git grep -w proutil is empty after the change). cmdutil has no existing identifier or package collision in the touched files.

Validation

  • mkdir -p dist && go build ./...: pass
  • GOOS=windows go vet ./cmd/pro/...: pass
  • mise run cli:format: no changes
  • mise run cli:lint:ci: pass
  • go test ./cmd/pro/...: pass
  • Diff comment scan: only added comment line is the renamed package doc line.
  • Pro-token count, cmd/pro (\bpro\b, Pro(?=[A-Z0-9_]|\b), (^|[^A-Za-z])pro(?=[A-Z]), DEVSY_PRO(_|$); excludes go.sum, renovate.json, .github): 131 before, 131 after. Expected: the package name proutil does not match these regexes; the cmd/pro/ path segment is unchanged.

CodeRabbit CLI

Failed to run: coderabbit review --agent --committed returned rate_limit ("used all 3 included reviews", wait 12 minutes). No findings produced. The GitHub CodeRabbit review still gates.

Auto-merge

Eligible under the rename-migration rules: T1, 100 non-test changed lines (50 added, 50 removed), 16 non-test files (17 total including the test rename). Caveat: the auto-refactor step 2 cap is 12 files excluding tests, which this PR exceeds; the rename cap is 25. The coordinator should confirm which cap applies.

Remaining

cmd/pro Pro-token count: 131 before, 131 after (unchanged by this PR; the cmd/pro/ path segment matches \bpro\b before and after).

Summary by CodeRabbit

  • Refactor
    • Standardized host-related command behavior across update checks, cluster and project listings, daemon and health commands, version information, and workspace operations. Existing command functionality and output remain unchanged.

@skevetter skevetter added the rename Loft/Pro rename label Oct 23, 2026
@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit a1426c2
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6adb064540d8d6169cc12ee1

@netlify

netlify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit a1426c2
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6adb0645d3ba9054b940bb46

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 65049ba1-4913-4ce0-8536-3fcd0ed30689
📥 Commits

Reviewing files that changed from the base of the PR and between f8bc546 and a1426c2.

📒 Files selected for processing: 17
  • cmd/pro/check_update.go
  • cmd/pro/cluster/list.go
  • cmd/pro/cmdutil/cmdutil.go
  • cmd/pro/cmdutil/cmdutil_test.go
  • cmd/pro/daemon/netcheck.go
  • cmd/pro/daemon/start.go
  • cmd/pro/daemon/status.go
  • cmd/pro/health.go
  • cmd/pro/project/list.go
  • cmd/pro/self.go
  • cmd/pro/template/list.go
  • cmd/pro/update_provider.go
  • cmd/pro/version.go
  • cmd/pro/workspace/create.go
  • cmd/pro/workspace/list.go
  • cmd/pro/workspace/update.go
  • cmd/pro/workspace/watch.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The Pro command utility package is renamed from proutil to cmdutil. Pro commands now use cmdutil for host execution, host flags, provider lookup, and table headers. The update-checking and other command logic remains unchanged.

Changes: Pro command utility rename

Layer / File(s) Summary
Rename the utility package
cmd/pro/cmdutil/cmdutil.go, cmd/pro/cmdutil/cmdutil_test.go
The package and test package declarations now use cmdutil.
Update Pro command references
cmd/pro/check_update.go, cmd/pro/cluster/list.go, cmd/pro/daemon/*, cmd/pro/health.go, cmd/pro/project/list.go, cmd/pro/self.go, cmd/pro/template/list.go, cmd/pro/update_provider.go, cmd/pro/version.go, cmd/pro/workspace/*
Commands now reference cmdutil instead of proutil for host execution, host flags, provider lookup, and table headers.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related issues

  • devsy-org/devsy#1551 tracks the Pro utility package rename to cmdutil; this pull request implements that checklist item.
Merge Risk: ⚪ Minimal · up to a1426

The PR is a consistent package rename with no identified behavior change or merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: renaming the internal proutil package to cmdutil.
Description check Passed The description explains what changed, why it changed, the scope, and validation results. It omits several template sections, including explicit type and AI-assistance checkboxes, manual verification …
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 17 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains what changed, why it changed, the scope, and validation results. It omits several template sections, including explicit type and AI-assistance checkboxes, manual verification details, and checklist confirmations, but it provides the core information for this refactor.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as ready for review October 23, 2026 08:49
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mergify

mergify Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit 2ea3322 into main Oct 23, 2026
114 checks passed
@skevetter
skevetter deleted the refactor/pro-rename-proutil-package branch October 23, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/m

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant