Skip to content

refactor(e2e): scope vscode settings HOME with SetEnvForSpec #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Oct 23, 2026
Merged

refactor(e2e): scope vscode settings HOME with SetEnvForSpec #1673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions e2e/tests/ide/vscode_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,21 @@ const settingEditorFontSize = "editor.fontSize"
var _ = ginkgo.Describe("VS Code Settings JSONC Handling", ginkgo.Label("ide"), func() {
var (
tmpHome string
origHome string
settingsDir string
)

ginkgo.BeforeEach(func() {
var err error
origHome = os.Getenv("HOME")

tmpHome, err = os.MkdirTemp("", "vscode-settings-test-*")
framework.ExpectNoError(err)
ginkgo.DeferCleanup(func() { _ = os.RemoveAll(tmpHome) })

// On Linux, VS Code settings live at ~/.config/Code/User/settings.json
settingsDir = filepath.Join(tmpHome, ".config", "Code", "User")
err = os.MkdirAll(settingsDir, 0o750)
framework.ExpectNoError(err)

err = os.Setenv("HOME", tmpHome)
framework.ExpectNoError(err)
})

ginkgo.AfterEach(func() {
err := os.Setenv("HOME", origHome)
framework.ExpectNoError(err)
_ = os.RemoveAll(tmpHome)
framework.SetEnvForSpec("HOME", tmpHome)
})

settingsPath := func() string {
Expand Down
Loading