Skip to content

refactor(e2e): assert browser tunnel idle survival #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Oct 23, 2026
Merged

refactor(e2e): assert browser tunnel idle survival #1676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions e2e/tests/ide/browser_returns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,12 @@ var _ = ginkgo.Describe(
}).WithTimeout(30*time.Second).WithPolling(500*time.Millisecond).
Should(gomega.Succeed(), "helper port-forward at %s never came up", addr)

// Now sleep past the OLD 5s idle window with NO connections.
time.Sleep(8 * time.Second)
// The helper must outlive an idle period with no client connections.
gomega.Consistently(func() error {
return syscall.Kill(state.PID, 0)
}).WithTimeout(8*time.Second).WithPolling(500*time.Millisecond).
Should(gomega.Succeed(),
"expected helper PID %d to stay alive through 8s idle", state.PID)

// And the listener must still accept.
conn, err := net.DialTimeout("tcp", addr, 3*time.Second)
Expand Down
Loading