feat: biome#3110
Open
AbhishekA1509 wants to merge 3 commits into
Open
Conversation
…nto feat/biome
- Updated type annotations for state variables and function parameters in ChartDeploymentHistory, DevtronStackManager, and other components to enhance type safety. - Replaced legacy `==` comparisons with strict `===` where applicable. - Simplified error handling by removing unused error variables in async functions. - Improved accessibility by adding `alt` attributes to images and ARIA labels to elements. - Refactored event handlers to avoid passing unnecessary parameters. - Cleaned up unused variables and imports across multiple files. - Added comments to suppress specific linting rules for legacy code.
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
Bot
added
the
PR:Issue-verification-failed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates the project's code formatting and linting setup from ESLint and Prettier to Biome, a new all-in-one code formatter and linter. The changes remove the previous ESLint and Prettier configuration files, update VSCode settings to use Biome for formatting and fixing issues, and adjust the
lint-stagedconfiguration to use Biome for code checks.Migration to Biome for Formatting and Linting
Tooling and Configuration Updates:
.eslintrc.jsand.prettierrc.jsfiles, eliminating all ESLint and Prettier configuration and rules from the project. [1] [2].eslintignoreby removing all ignore patterns and file references, as ESLint is no longer used.Editor and Workflow Integration:
.vscode/settings.jsonto set Biome as the default formatter for TypeScript, TypeScript React, and JSON files. Enabled format-on-save and configured code actions to use Biome for fixes, while disabling Prettier and ESLint extensions..lintstagedrcto runbiome check --writeinstead ofeslintfor staged file checks, ensuring consistent formatting and linting in pre-commit hooks.Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: