Skip to content

feat: add support for extra build flags set #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhupesh-devtron merged 3 commits into from
Sep 10, 2026
Merged

feat: add support for extra build flags set #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e65d35c
feat: add support for extra build flags set
bhupesh-devtron Aug 21, 2026
a09bbd6
fix: remove redundant code
bhupesh-devtron Aug 26, 2026
9568832
Merge branch 'develop' into feat/extra-build-flags
bhupesh-devtron Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci-runner/helper/DockerHelper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,9 @@ func (impl *DockerHelperImpl) BuildArtifact(ciRequest *CommonWorkflowRequest) (s
for key, value := range dockerBuildFlags {
dockerBuild = dockerBuild + " " + key + value
}
for _, flag := range dockerBuildConfig.ExtraBuildFlags {
dockerBuild = dockerBuild + " " + flag
}
if !ciRequest.EnableBuildContext || dockerBuildConfig.BuildContext == "" {
dockerBuildConfig.BuildContext = ROOT_PATH
}
Expand Down
3 changes: 3 additions & 0 deletions ci-runner/helper/EventHelper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ type DockerBuildConfig struct {
BuildxProvenanceMode string `json:"buildxProvenanceMode"`
BuildxK8sDriverOptions []map[string]string `json:"buildxK8SDriverOptions"`

// ExtraBuildFlags is an opaque list of already-formatted docker build flags
ExtraBuildFlags []string `json:"extraBuildFlags,omitempty"`

//ent only
BuildxDriverImage string `json:"buildxDriverImage"`
}
Expand Down
Loading