Repository navigation
feat: add Decline (veto) notification — DeploymentDeclined event type 16 - #172
Merged
mayank-devtron merged 2 commits intoSep 10, 2026
Merged
Conversation
Add event type 16 for deployment approval decline (veto by super-admin). Follows the same pattern as DeploymentCancelled (event 13): - New enum value and parsed event interface in types.ts - Parsing branch in mustacheHelper.ts - Slack/SES/SMTP Mustache templates (16.mustache) - Excluded from CI/CD material parsing guard Uses standard notification routing (not the approval-specific path), matching the convention for cancelled events (13-15). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mayank-devtron
force-pushed
the
feat/deployment-approval-declined-notification
branch
from
September 1, 2026 21:41
c9fd24c to
d56d10e
Compare
…path sendNotificationV2 only read event.payload.providers for the approval/ approved event types, so declined events (16) fell through to the settings path, found no settings, and were dropped. Add DeploymentDeclined to that list so it uses the providers the orchestrator attaches (eligible approvers + requester) and renders the event-16 templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mayank-devtron
marked this pull request as ready for review
September 7, 2026 03:57
shivani170
approved these changes
Sep 10, 2026
vivek-devtron
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds notifier support for the new DeploymentDeclined event (type
16) — the super-admin veto action in the deployment-approval flow. When a super-admin declines a pending approval request, the orchestrator emits event 16 and this lets the notifier render Slack / SES / SMTP notifications for it.How
Mirrors the existing DeploymentCancelled (
13) pattern exactly — Decline is the same shape as Cancel, just a different actor/wording:types.ts—EVENT_TYPE.DeploymentDeclined = 16and aParseDeploymentDeclinedEventinterface (identical fields toParseDeploymentCancelledEvent)mustacheHelper.ts— a parse branch identical to the cancelled one; added to theparseEventreturn union and to the CI/CD material-parsing exclusion guardtemplates/{slack,ses,smtp}/CD/16.mustache— byte-identical to the cancelled13.mustachetemplates except the wording (❌→🚫,Cancelled→Declined)notificationService.ts—sendNotificationV2now treats 16 as an approval-family event so it readsevent.payload.providers(like 4/5/7/10/11/12). Without this, decline events fell through to the settings path, found no settings, and were dropped — the bug behind "notification not received".Net diff is additive (+84/−4, 6 files); no existing event handling is changed.
tscpasses clean.Related
Part of the cross-repo deployment-approval Decline (veto) feature:
Test plan
🤖 Generated with Claude Code