Skip to content

DO NOT MERGE PR 10857 needs to be fully in production first feat(registry): Enable blank replica_version_id for engines. #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-wong-dfinity-org-twin wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

DO NOT MERGE PR 10857 needs to be fully in production first feat(registry): Enable blank replica_version_id for engines. #10888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rs/registry/canister/src/flags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ thread_local! {
static IS_SUBNET_SPLITTING_ENABLED: Cell<bool> = const { Cell::new(false) };
static IS_CHUNKIFYING_LARGE_VALUES_ENABLED: Cell<bool> = const { Cell::new(true) };
static IS_NODE_SWAPPING_ENABLED: Cell<bool> = const { Cell::new(true) };
static IS_BLANK_REPLICA_VERSION_ID_FOR_CLOUD_ENGINES_ENABLED: Cell<bool> = const { Cell::new(false) };
static IS_BLANK_REPLICA_VERSION_ID_FOR_CLOUD_ENGINES_ENABLED: Cell<bool> = const { Cell::new(true) };

@bjoernek bjoernek Jul 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flipping this makes the doc comment on check_replica_version_invariants false. rs/registry/canister/src/invariants/replica_version.rs:34-38 still reads:

Exception: a CloudEngine can have a blank replica_version_id in its SubnetRecord if there is a StandardEngineReplicaVersionRecord. As of July 22, 2026, this feature is disabled via a flag (but the plan is to enable it in the not too distant future).

The first sentence is still accurate; the second is falsified by this PR. Could you update it here, so we don't leave a "this is disabled" comment sitting next to code that is now enabled? Suggested replacement:

/// Exception: a CloudEngine is allowed to have a blank replica_version_id in
/// its SubnetRecord, provided a StandardEngineReplicaVersionRecord exists. In
/// that case, that record determines the Cloud Engine's replica version.

(Commenting here rather than inline, since replica_version.rs isn't part of this diff.)


// Temporary flags related to the node swapping feature.
//
Expand Down
4 changes: 4 additions & 0 deletions rs/registry/canister/unreleased_changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on the process that this file is part of, see

## Changed

* Cloud Engines are now allowed to have blank `replica_version_id` (in their
`SubnetRecord`). In this case, `StandardEngineReplicaVersionRecord` is used to
determine the Cloud Engine's replica version.

## Deprecated

## Removed
Expand Down
Loading