feat(http-outcalls): CON-1686 disregard reject responses when building payload for flexible outcall#9572
Merged
fspreiss merged 8 commits intoMar 27, 2026
Conversation
…g payload for flexible outcall
eichhorl
approved these changes
Mar 26, 2026
Contributor
eichhorl
left a comment
eichhorl
left a comment
There was a problem hiding this comment.
In a follow-up PR, to aid with debugging, we will adapt the payload builder to include Reject responses in the node_details of the flexible_http_request_err whenever a call to flexible_http_request times out.
I guess alternatively we could already produce a response as soon as we have more than n-min reject responses? Because we would never receive enough success responses.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
fspreiss
deleted the
fspreiss/CON-1686-disregard-rejects-in-flex-payload-building
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 28, 2026
…cution (#9564) Implements the `IntoMessages` path for flexible HTTP outcall ok-responses, converting each `FlexibleCanisterHttpResponses` group from the consensus payload into a single Candid-encoded `ConsensusResponse` for delivery to the execution environment. For each flexible response group, the individual `CanisterHttpResponsePayloads` (already Candid-encoded by the HTTP adapter) are decoded, collected into a `Vec`, wrapped in `FlexibleHttpRequestResult::Ok(vec![...])`, and re-encoded as a single `Payload::Data` for the canister callback. Reject entries (infrastructure-level failures like DNS/network errors) are filtered out as this path is unrechable due to payload building/validation ensuring that no reject responses are included in the ok-payload (see #9572). If Candid decoding or encoding fails, the delivery of the response is skipped and a timeout will eventually gracefully end the outstanding callback. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts the HTTP outcalls payload builder for flexible calls to filter out reject responses when trying to find a viable ok-response group.
Currently,
find_flexible_responsespicks up responses from the pool viaget_response_content_by_hash, which returns the fullCanisterHttpResponseincludingRejectcontent. It doesn't filter by content type -- any response from a valid committee member gets included, whetherSuccessorReject.According to the spec an
okresult isvec http_request_result(status, headers, body). ARejectcan't be meaningfully represented as anhttp_request_result. The canister calledflexible_http_requestto get HTTP responses: a node that couldn't reach the server didn't produce a useful HTTP response.The
min_responsesthreshold still applies after filtering -- if too many nodes producedRejectand we can't reachmin_responsessuccesses, the group isn't included and the request will eventually time out.In a follow-up PR, to aid with debugging, we will adapt the payload builder to include
Rejectresponses in thenode_detailsof the flexible_http_request_err whenever a call toflexible_http_requesttimes out.