fix: Don't print response in -o hex --json#553
Merged
Conversation
lwshang
previously approved these changes
May 13, 2026
Each output-mode arm previously forked on `--json`, duplicating the "decode and stash vs. decode and print" logic. The recent `-o hex --json` double-printing bug was a direct consequence — easy to forget one of the `if !args.json` guards. Split the flow into a `decode_response` step that returns a `Decoded` enum (Candid / Text / Bytes) and a single emission step that forks on `--json` exactly once. Semantics are unchanged: `-o` still controls decoding strictness, `--json` still controls envelope vs. human output, and the two remain orthogonal. The write-vs-decode error reconciliation in JSON mode is preserved. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
lwshang
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.