Skip to content

Remove dead code and duplication in the server and TUI; fix docs claims - #25

Merged
dgsienko merged 9 commits into
mainfrom
slop-dead-code
Oct 23, 2026
Merged

dgsienko merged 9 commits into
mainfrom
slop-dead-code

Conversation

@dgsienko

Copy link
Copy Markdown
Owner

Fixes from a full-repo slop audit, Python and docs half. Every finding was re-checked against the code before it was fixed.

  • Dead code: the delete_bg/delete_hover theme fields (equal to remove_* in all 16 themes), get_git_user_name, reload_branch_name, the write-only current_view, the unused view_mode setting, and the unused dim parameter on the TUI's style()
  • The active theme is derived from theme_index, not a second module global. Settings are built in one AppState.settings() and not three times.
  • Word highlights use one toggle block and drop guards for input html.escape can't produce
  • Function-local imports are hoisted where nothing needs them local
  • README: kroki gets every diagram language, not only mermaid and plantuml, and .diffuiignore only applies to changed-scope search. AGENTS.md drops sections that restated the README.

Behavior changes: none a user would see. view_mode disappears from /api/settings, and nothing read it. Theme switching through the settings API gets a feature test, since the old one tested the deleted global.

Version 0.11.1.

@dgsienko
dgsienko merged commit 1b77ebf into main Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant