Repository navigation
Clean up the web frontend and split app.js - #26
Merged
Merged
Conversation
…narrow startup catches
…r, palette counter
… and em-dashes in comments
# Conflicts: # AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a full-repo slop audit, web half.
showIgnoredstate, the Diff Stats Bar CSS block, settings close transitions, the unused warn colors, and guards for states callers never producelib/keys.js(they were in four places)sendJsonandcommentUrlhelpers replace seven hand-built JSON fetchescomponents/CommentThread.jsapp.jsgoes from 1188 to 637 lines. The split moves its hooks intolib/(live events, comments, keyboard, agent, scroll, copy, search, appearance, session save) and the empty and loading states into a component.Two behavior changes, both intended. The
rkey could refetch the file list for a stale view, and now uses the current one. Settings changes apply right away, before the save returns.Checked in a browser against a scratch repo: file switching, all three diff views, comments, search, the palette, the shortcut overlay, rebinding a key, and mark reviewed. There were no console errors.