Fix cl-assertion-failed in diff-hl-revert-hunk caused by track-changes#287
Open
jamescherti wants to merge 1 commit into
Open
Fix cl-assertion-failed in diff-hl-revert-hunk caused by track-changes#287jamescherti wants to merge 1 commit into
jamescherti wants to merge 1 commit into
Conversation
jamescherti
force-pushed
the
bug-revert-hunk-cl-assertion-failed
branch
from
7120fbc to
376606a
Compare
jamescherti
force-pushed
the
bug-revert-hunk-cl-assertion-failed
branch
from
376606a to
81b7628
Compare
jamescherti
force-pushed
the
bug-revert-hunk-cl-assertion-failed
branch
2 times, most recently
from
5a8e149 to
c73cab3
Compare
It disables track-changes-mode inside the temporary diff-hl-revert buffer. This prevents asynchronous background timers from firing while execution is suspended at the yes-or-no-p prompt. Because the buffer is narrowed to highlight the hunk, the tracker previously attempted to access coordinates outside the visible region, causing an assertion failure.
jamescherti
force-pushed
the
bug-revert-hunk-cl-assertion-failed
branch
from
c73cab3 to
ac1b266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #286
It disables track-changes-mode inside the temporary diff-hl-revert buffer. This prevents asynchronous background timers from firing while execution is suspended at the yes-or-no-p prompt.
Because the buffer is narrowed to highlight the hunk, the tracker previously attempted to access coordinates outside the visible region, causing an assertion failure.