Repository navigation
Conversation
Pins native iOS and Android to 4.10.0, drops the temporary native source pin, maps iOS Location to the native Location variants, raises the Android Kotlin default to 2.1.20, and adds release notes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codex review ( 💡 Code reviewReviewed commit:
When an app selects Verdict: REQUEST CHANGES |
Native 4.10.0 still publishes didit-sdk-autodetection and DiditSDK/AutoDetection, but empty and identical to core, and its release notes tell apps to drop them. The wrapper now depends on core directly (didit-sdk-core, DiditSDK/Core, DiditSDKCore), so the deprecated hop is gone and the Location mapping needs no special case. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Round 1 finding (map Android autodetection to core): fixed in f3116a9, on both platforms. One correction to its premise: native 4.10.0 does still publish |
|
Codex review ( 💡 Code reviewReviewed commit: No blocking findings in commit Verdict: APPROVE |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Do not merge before sdk-ios 4.10.0 and sdk-android 4.10.0 are published (2026-11-01)
The pins below resolve native 4.10.0 binaries that do not exist yet. Native example builds (
example,example-expo) fail until then. After the native releases are out, merge, tagv4.10.0(the release workflow readsrelease-notes/4.10.0.md) and publish.Summary
package.jsonversion anddiditNativeSdkVersions.ios/.androidset to 4.10.0. The temporarydiditNativeSdkVersions.sourcedevelopment pin is removed. Thenative-sdk-source.jsmechanism stays and is a no-op without asourcekey (covered by a test).SdkReactNative.podspec, the Expo config plugin and both example Podfiles declare exactly one subspec: all ->DiditSDK/All-Location, core and autodetection ->DiditSDK/Core-Location, nfc ->DiditSDK/NFC-Location. SwiftPM usesDiditSDKLocation,DiditSDKCoreLocation,DiditSDKNFCLocation, and no longer raises "Location requires CocoaPods linkage". TheCore-Location,NFC-LocationandAll-Locationfolders are added toFRAMEWORK_SEARCH_PATHS.release-notes/4.10.0.mdadded.packages/auth-react-nativeis private, version 0.0.0 and declares no native DiditAuth dependency, so there are no pins to bump and it does not ship in this release. Its version is not touched.Verification
yarn test: 14 of 15 suites pass. The one failure,packages/auth-react-native/src/__tests__/packaging.test.ts(autolinking), fails identically on an untouchedmaincheckout because the localnode_moduleslacks the workspace links; it is unrelated to this change.yarn typecheckandyarn lintexit 0.🤖 Generated with Claude Code