feat: Check if saved files exists and raise an early error if they do#223
Merged
sbillinge merged 8 commits intodiffpy:mainfrom Apr 2, 2026
Merged
feat: Check if saved files exists and raise an early error if they do#223sbillinge merged 8 commits intodiffpy:mainfrom
sbillinge merged 8 commits intodiffpy:mainfrom
Conversation
Contributor
Author
|
@sbillinge ready for review |
Contributor
Author
|
Ah, it's failing |
sbillinge
reviewed
Apr 2, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
I reviewed the ocde. modulo a couple of small comments it looks good. Let me know when tests are passing and I can merge.
| if outfile.exists() and not args.force: | ||
| print(f"WARNING: {outfile} exists. Use --force to overwrite.") | ||
| return | ||
| outfile = args.output_directory / (input_path.stem + "-mud-corrected.chi") |
Contributor
There was a problem hiding this comment.
no biggie, but as a general rule, let's compose as f-strings, not using +
src/diffpy/labpdfproc/tools.py
Outdated
| and output directory.""" | ||
| existing_files = [] | ||
| for path in args.input_paths: | ||
| outfile = args.output_directory / (path.stem + "-mud-corrected.chi") |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 99.13% 99.17% +0.04%
==========================================
Files 5 5
Lines 345 364 +19
==========================================
+ Hits 342 361 +19
Misses 3 3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #220
Before, this was just a print statement which was confusing. Now an error is raised if the output file already exists.